Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #687, validate table handle prior to use #688

Merged
merged 1 commit into from
May 19, 2020
Merged

Fix #687, validate table handle prior to use #688

merged 1 commit into from
May 19, 2020

Conversation

CDKnightNASA
Copy link
Contributor

@CDKnightNASA CDKnightNASA commented May 7, 2020 •
edited by skliper
Loading

Describe the contribution
fixes a bug where a table handle is used prior to validation (used in the variable initialization at the top of CFE_TBL_Load() .)

Fix #687

Contributor Info - All information REQUIRED for consideration of pull request
[email protected]

@CDKnightNASA CDKnightNASA added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 7, 2020
@CDKnightNASA CDKnightNASA self-assigned this May 7, 2020
@skliper
Copy link
Contributor

skliper commented May 7, 2020

Squash these (just don't assign NULL):

[fsw/cfe-core/src/tbl/cfe_tbl_api.c:681] -> [fsw/cfe-core/src/tbl/cfe_tbl_api.c:689]: (style) Variable 'AccessDescPtr' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/tbl/cfe_tbl_api.c:682] -> [fsw/cfe-core/src/tbl/cfe_tbl_api.c:690]: (style) Variable 'RegRecPtr' is reassigned a value before the old one has been used.
[fsw/cfe-core/src/tbl/cfe_tbl_api.c:680] -> [fsw/cfe-core/src/tbl/cfe_tbl_api.c:696]: (style) Variable 'WorkingBufferPtr' is reassigned a value before the old one has been used.

jphickey
jphickey previously requested changes May 7, 2020
View reviewed changes
fsw/cfe-core/src/tbl/cfe_tbl_api.c Show resolved Hide resolved
@CDKnightNASA
Copy link
Contributor Author

updated, squashed, pushed, better? :)

@skliper skliper added this to the 6.8.0 milestone May 12, 2020
@astrogeco astrogeco changed the title fix #687 - validate table handle prior to use Fix #687 - validate table handle prior to use May 13, 2020
@astrogeco astrogeco changed the title Fix #687 - validate table handle prior to use Fix #687, validate table handle prior to use May 13, 2020
@skliper skliper added CCB-20200513 enhancement and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 13, 2020
@skliper
Copy link
Contributor

skliper commented May 13, 2020

CCB 20200513 - Approved

@astrogeco astrogeco dismissed jphickey’s stale review May 19, 2020 20:07

Changes applied

@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB IC-20200513 labels May 19, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate May 19, 2020 20:07
@astrogeco astrogeco merged commit 0fa7baf into nasa:integration-candidate May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper approved these changes

@jphickey jphickey jphickey left review comments

Assignees

@CDKnightNASA CDKnightNASA

Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

TblHandle used before validation in CFE_TBL_Load
4 participants
@CDKnightNASA @skliper @jphickey @astrogeco